YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove redundant extern keywords from function declarations/definitions. (#1495)

Browse Source 
Extern keywords on function declarations/definitions provide no additional value since function declarations/definitions default to external linkage in C99, e.g. removing them won't change the semantics of the program.

The extern keywords were essentially a legacy from the early days of the project. This commit cleans this up across the whole codebase in one go to minimize history disruption.

The bulk of the changes in this commit were produced by a custom clang-tidy checker.

Note that variables declarations carrying the extern keyword are untouched by this commit since there the presence of the keyword actually has an impact on the semantics of the program.

JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller t.scheller@samsung.com
This commit is contained in:
Tilmann Scheller
2016-12-16 10:18:37 +01:00
committed by GitHub
parent defd97cc51
commit 1e99be90c3
43 changed files with 451 additions and 451 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/jmem/jmem-allocator-internal.h
+1 -1
View File
@@ -24,7 +24,7 @@
* @{
*/
extern void jmem_run_free_unused_memory_callbacks (jmem_free_unused_memory_severity_t);
void jmem_run_free_unused_memory_callbacks (jmem_free_unused_memory_severity_t);
/**
* @}
jerry-core/jmem/jmem-allocator.h
+8 -8
View File
@@ -151,18 +151,18 @@ typedef void (*jmem_free_unused_memory_callback_t) (jmem_free_unused_memory_seve
} \
} while (false);
extern void jmem_init (void);
extern void jmem_finalize (void);
void jmem_init (void);
void jmem_finalize (void);
extern jmem_cpointer_t jmem_compress_pointer (const void *);
extern void *jmem_decompress_pointer (uintptr_t);
jmem_cpointer_t jmem_compress_pointer (const void *);
void *jmem_decompress_pointer (uintptr_t);
extern void jmem_register_free_unused_memory_callback (jmem_free_unused_memory_callback_t);
extern void jmem_unregister_free_unused_memory_callback (jmem_free_unused_memory_callback_t);
void jmem_register_free_unused_memory_callback (jmem_free_unused_memory_callback_t);
void jmem_unregister_free_unused_memory_callback (jmem_free_unused_memory_callback_t);
#ifdef JMEM_STATS
extern void jmem_stats_reset_peak (void);
extern void jmem_stats_print (void);
void jmem_stats_reset_peak (void);
void jmem_stats_print (void);
#endif /* JMEM_STATS */
/**
jerry-core/jmem/jmem-heap.h
+10 -10
View File
@@ -28,12 +28,12 @@
* @{
*/
extern void jmem_heap_init (void);
extern void jmem_heap_finalize (void);
extern void *jmem_heap_alloc_block (const size_t);
extern void *jmem_heap_alloc_block_null_on_error (const size_t);
extern void jmem_heap_free_block (void *, const size_t);
extern bool jmem_is_heap_pointer (const void *);
void jmem_heap_init (void);
void jmem_heap_finalize (void);
void *jmem_heap_alloc_block (const size_t);
void *jmem_heap_alloc_block_null_on_error (const size_t);
void jmem_heap_free_block (void *, const size_t);
bool jmem_is_heap_pointer (const void *);
#ifdef JMEM_STATS
/**
@@ -62,9 +62,9 @@ typedef struct
size_t free_iter_count;
} jmem_heap_stats_t;
extern void jmem_heap_get_stats (jmem_heap_stats_t *);
extern void jmem_heap_stats_reset_peak (void);
extern void jmem_heap_stats_print (void);
void jmem_heap_get_stats (jmem_heap_stats_t *);
void jmem_heap_stats_reset_peak (void);
void jmem_heap_stats_print (void);
#endif /* JMEM_STATS */
#ifdef JERRY_VALGRIND_FREYA
@@ -73,7 +73,7 @@ extern void jmem_heap_stats_print (void);
#error Valgrind and valgrind-freya modes are not compatible.
#endif /* JERRY_VALGRIND */
extern void jmem_heap_valgrind_freya_mempool_request (void);
void jmem_heap_valgrind_freya_mempool_request (void);
#define JMEM_HEAP_VALGRIND_FREYA_MEMPOOL_REQUEST() jmem_heap_valgrind_freya_mempool_request ()
jerry-core/jmem/jmem-poolman.h
+7 -7
View File
@@ -28,10 +28,10 @@
* @{
*/
extern void jmem_pools_finalize (void);
extern void *jmem_pools_alloc (size_t);
extern void jmem_pools_free (void *, size_t);
extern void jmem_pools_collect_empty (void);
void jmem_pools_finalize (void);
void *jmem_pools_alloc (size_t);
void jmem_pools_free (void *, size_t);
void jmem_pools_collect_empty (void);
#ifdef JMEM_STATS
/**
@@ -58,9 +58,9 @@ typedef struct
size_t reused_count;
} jmem_pools_stats_t;
extern void jmem_pools_get_stats (jmem_pools_stats_t *);
extern void jmem_pools_stats_reset_peak (void);
extern void jmem_pools_stats_print (void);
void jmem_pools_get_stats (jmem_pools_stats_t *);
void jmem_pools_stats_reset_peak (void);
void jmem_pools_stats_print (void);
#endif /* JMEM_STATS */
/**