Remove redundant extern keywords from function declarations/definitions. (#1495)

Extern keywords on function declarations/definitions provide no additional value since function declarations/definitions default to external linkage in C99, e.g. removing them won't change the semantics of the program.

The extern keywords were essentially a legacy from the early days of the project. This commit cleans this up across the whole codebase in one go to minimize history disruption.

The bulk of the changes in this commit were produced by a custom clang-tidy checker.

Note that variables declarations carrying the extern keyword are untouched by this commit since there the presence of the keyword actually has an impact on the semantics of the program.

JerryScript-DCO-1.0-Signed-off-by: Tilmann Scheller t.scheller@samsung.com

jerry-core/ecma/operations/ecma-array-object.c

@@ -137,7 +137,7 @@ ecma_op_create_array_object (const ecma_value_t *arguments_list_p, /**< list of
  * @return ecma value
  *         Returned value must be freed with ecma_free_value
  */
-extern ecma_value_t
+ecma_value_t
 ecma_op_array_object_set_length (ecma_object_t *object_p, /**< the array object */
                                  ecma_value_t new_value, /**< new length value */
                                  uint32_t flags) /**< configuration options */

jerry-core/ecma/operations/ecma-array-object.h

@@ -39,16 +39,16 @@ typedef enum
                                                          *   in the property descriptor */
 } ecma_array_object_set_length_flags_t;
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_create_array_object (const ecma_value_t *, ecma_length_t, bool);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_array_object_set_length (ecma_object_t *, ecma_value_t, uint32_t);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_array_object_define_own_property (ecma_object_t *, ecma_string_t *, const ecma_property_descriptor_t *, bool);
 
-extern void
+void
 ecma_op_array_list_lazy_property_names (ecma_object_t *, bool,
                                         ecma_collection_header_t *, ecma_collection_header_t *);
 

jerry-core/ecma/operations/ecma-arraybuffer-object.h

@@ -25,17 +25,17 @@
  * @{
  */
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_create_arraybuffer_object (const ecma_value_t *, ecma_length_t);
 
 /**
  * Helper functions for arraybuffer.
  */
-extern ecma_object_t *
+ecma_object_t *
 ecma_arraybuffer_new_object (ecma_length_t);
-extern lit_utf8_byte_t *
+lit_utf8_byte_t *
 ecma_arraybuffer_get_buffer (ecma_object_t *) __attr_pure___;
-extern ecma_length_t
+ecma_length_t
 ecma_arraybuffer_get_length (ecma_object_t *) __attr_pure___;
 
 /**

jerry-core/ecma/operations/ecma-boolean-object.h

@@ -25,7 +25,7 @@
  * @{
  */
 
-extern ecma_value_t ecma_op_create_boolean_object (ecma_value_t);
+ecma_value_t ecma_op_create_boolean_object (ecma_value_t);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-comparison.h

@@ -26,9 +26,9 @@
  * @{
  */
 
-extern ecma_value_t ecma_op_abstract_equality_compare (ecma_value_t, ecma_value_t);
-extern bool ecma_op_strict_equality_compare (ecma_value_t, ecma_value_t);
-extern ecma_value_t ecma_op_abstract_relational_compare (ecma_value_t, ecma_value_t, bool);
+ecma_value_t ecma_op_abstract_equality_compare (ecma_value_t, ecma_value_t);
+bool ecma_op_strict_equality_compare (ecma_value_t, ecma_value_t);
+ecma_value_t ecma_op_abstract_relational_compare (ecma_value_t, ecma_value_t, bool);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-conversion.h

@@ -37,16 +37,16 @@ typedef enum
   ECMA_PREFERRED_TYPE_STRING /**< String */
 } ecma_preferred_type_hint_t;
 
-extern ecma_value_t ecma_op_check_object_coercible (ecma_value_t);
-extern bool ecma_op_same_value (ecma_value_t, ecma_value_t);
-extern ecma_value_t ecma_op_to_primitive (ecma_value_t, ecma_preferred_type_hint_t);
-extern bool ecma_op_to_boolean (ecma_value_t);
-extern ecma_value_t ecma_op_to_number (ecma_value_t);
-extern ecma_value_t ecma_op_to_string (ecma_value_t);
-extern ecma_value_t ecma_op_to_object (ecma_value_t);
+ecma_value_t ecma_op_check_object_coercible (ecma_value_t);
+bool ecma_op_same_value (ecma_value_t, ecma_value_t);
+ecma_value_t ecma_op_to_primitive (ecma_value_t, ecma_preferred_type_hint_t);
+bool ecma_op_to_boolean (ecma_value_t);
+ecma_value_t ecma_op_to_number (ecma_value_t);
+ecma_value_t ecma_op_to_string (ecma_value_t);
+ecma_value_t ecma_op_to_object (ecma_value_t);
 
-extern ecma_object_t *ecma_op_from_property_descriptor (const ecma_property_descriptor_t *);
-extern ecma_value_t ecma_op_to_property_descriptor (ecma_value_t, ecma_property_descriptor_t *);
+ecma_object_t *ecma_op_from_property_descriptor (const ecma_property_descriptor_t *);
+ecma_value_t ecma_op_to_property_descriptor (ecma_value_t, ecma_property_descriptor_t *);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-eval.h

@@ -25,10 +25,10 @@
  * @{
  */
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_eval (ecma_string_t *, bool, bool);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_eval_chars_buffer (const lit_utf8_byte_t *, size_t, bool, bool);
 
 /**

jerry-core/ecma/operations/ecma-exceptions.h

@@ -48,16 +48,16 @@ typedef enum
   ECMA_ERROR_URI        /**< URIError */
 } ecma_standard_error_t;
 
-extern ecma_object_t *ecma_new_standard_error (ecma_standard_error_t);
-extern ecma_object_t *ecma_new_standard_error_with_message (ecma_standard_error_t, ecma_string_t *);
-extern ecma_value_t ecma_raise_standard_error (ecma_standard_error_t, const lit_utf8_byte_t *);
-extern ecma_value_t ecma_raise_common_error (const char *);
-extern ecma_value_t ecma_raise_eval_error (const char *);
-extern ecma_value_t ecma_raise_range_error (const char *);
-extern ecma_value_t ecma_raise_reference_error (const char *);
-extern ecma_value_t ecma_raise_syntax_error (const char *);
-extern ecma_value_t ecma_raise_type_error (const char *);
-extern ecma_value_t ecma_raise_uri_error (const char *);
+ecma_object_t *ecma_new_standard_error (ecma_standard_error_t);
+ecma_object_t *ecma_new_standard_error_with_message (ecma_standard_error_t, ecma_string_t *);
+ecma_value_t ecma_raise_standard_error (ecma_standard_error_t, const lit_utf8_byte_t *);
+ecma_value_t ecma_raise_common_error (const char *);
+ecma_value_t ecma_raise_eval_error (const char *);
+ecma_value_t ecma_raise_range_error (const char *);
+ecma_value_t ecma_raise_reference_error (const char *);
+ecma_value_t ecma_raise_syntax_error (const char *);
+ecma_value_t ecma_raise_type_error (const char *);
+ecma_value_t ecma_raise_uri_error (const char *);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-function-object.h

@@ -26,31 +26,31 @@
  * @{
  */
 
-extern bool ecma_op_is_callable (ecma_value_t);
-extern bool ecma_is_constructor (ecma_value_t);
+bool ecma_op_is_callable (ecma_value_t);
+bool ecma_is_constructor (ecma_value_t);
 
-extern ecma_object_t *
+ecma_object_t *
 ecma_op_create_function_object (ecma_object_t *, bool, const ecma_compiled_code_t *);
 
-extern void
+void
 ecma_op_function_list_lazy_property_names (bool,
                                            ecma_collection_header_t *,
                                            ecma_collection_header_t *);
 
-extern ecma_property_t *
+ecma_property_t *
 ecma_op_function_try_lazy_instantiate_property (ecma_object_t *, ecma_string_t *);
 
-extern ecma_object_t *
+ecma_object_t *
 ecma_op_create_external_function_object (ecma_external_pointer_t);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_function_call (ecma_object_t *, ecma_value_t,
                        const ecma_value_t *, ecma_length_t);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_function_construct (ecma_object_t *, const ecma_value_t *, ecma_length_t);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_function_has_instance (ecma_object_t *, ecma_value_t);
 
 /**

jerry-core/ecma/operations/ecma-lex-env.h

@@ -30,31 +30,31 @@
  * @{
  */
 
-extern void ecma_init_global_lex_env (void);
-extern void ecma_finalize_global_lex_env (void);
-extern ecma_object_t *ecma_get_global_environment (void);
+void ecma_init_global_lex_env (void);
+void ecma_finalize_global_lex_env (void);
+ecma_object_t *ecma_get_global_environment (void);
 
 /**
  * @}
  */
 
 /* ECMA-262 v5, 8.7.1 and 8.7.2 */
-extern ecma_value_t ecma_op_get_value_lex_env_base (ecma_object_t *, ecma_string_t *, bool);
-extern ecma_value_t ecma_op_get_value_object_base (ecma_value_t, ecma_string_t *);
-extern ecma_value_t ecma_op_put_value_lex_env_base (ecma_object_t *, ecma_string_t *, bool, ecma_value_t);
+ecma_value_t ecma_op_get_value_lex_env_base (ecma_object_t *, ecma_string_t *, bool);
+ecma_value_t ecma_op_get_value_object_base (ecma_value_t, ecma_string_t *);
+ecma_value_t ecma_op_put_value_lex_env_base (ecma_object_t *, ecma_string_t *, bool, ecma_value_t);
 
 /* ECMA-262 v5, Table 17. Abstract methods of Environment Records */
-extern bool ecma_op_has_binding (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_create_mutable_binding (ecma_object_t *, ecma_string_t *, bool);
-extern ecma_value_t ecma_op_set_mutable_binding (ecma_object_t *, ecma_string_t *, ecma_value_t, bool);
-extern ecma_value_t ecma_op_get_binding_value (ecma_object_t *, ecma_string_t *, bool);
-extern ecma_value_t ecma_op_delete_binding (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_implicit_this_value (ecma_object_t *);
+bool ecma_op_has_binding (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_create_mutable_binding (ecma_object_t *, ecma_string_t *, bool);
+ecma_value_t ecma_op_set_mutable_binding (ecma_object_t *, ecma_string_t *, ecma_value_t, bool);
+ecma_value_t ecma_op_get_binding_value (ecma_object_t *, ecma_string_t *, bool);
+ecma_value_t ecma_op_delete_binding (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_implicit_this_value (ecma_object_t *);
 
 /* ECMA-262 v5, Table 18. Additional methods of Declarative Environment Records */
-extern void ecma_op_create_immutable_binding (ecma_object_t *, ecma_string_t *, ecma_value_t);
+void ecma_op_create_immutable_binding (ecma_object_t *, ecma_string_t *, ecma_value_t);
 
-extern ecma_object_t *ecma_op_create_global_environment (ecma_object_t *);
+ecma_object_t *ecma_op_create_global_environment (ecma_object_t *);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-number-arithmetic.h

@@ -25,7 +25,7 @@
  * @{
  */
 
-extern ecma_number_t ecma_op_number_remainder (ecma_number_t, ecma_number_t);
+ecma_number_t ecma_op_number_remainder (ecma_number_t, ecma_number_t);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-number-object.h

@@ -25,7 +25,7 @@
  * @{
  */
 
-extern ecma_value_t ecma_op_create_number_object (ecma_value_t);
+ecma_value_t ecma_op_create_number_object (ecma_value_t);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-objects-arguments.h

@@ -19,13 +19,13 @@
 #include "ecma-globals.h"
 #include "ecma-helpers.h"
 
-extern void
+void
 ecma_op_create_arguments_object (ecma_object_t *, ecma_object_t *, const ecma_value_t *,
                                  ecma_length_t, const ecma_compiled_code_t *);
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_arguments_object_delete (ecma_object_t *, ecma_string_t *, bool);
-extern ecma_value_t
+ecma_value_t
 ecma_op_arguments_object_define_own_property (ecma_object_t *, ecma_string_t *,
                                               const ecma_property_descriptor_t *, bool);
 

jerry-core/ecma/operations/ecma-objects-general.h

@@ -26,15 +26,15 @@
  * @{
  */
 
-extern ecma_value_t ecma_reject (bool);
-extern ecma_object_t *ecma_op_create_object_object_noarg (void);
-extern ecma_value_t ecma_op_create_object_object_arg (ecma_value_t);
-extern ecma_object_t *ecma_op_create_object_object_noarg_and_set_prototype (ecma_object_t *);
+ecma_value_t ecma_reject (bool);
+ecma_object_t *ecma_op_create_object_object_noarg (void);
+ecma_value_t ecma_op_create_object_object_arg (ecma_value_t);
+ecma_object_t *ecma_op_create_object_object_noarg_and_set_prototype (ecma_object_t *);
 
-extern ecma_value_t ecma_op_general_object_delete (ecma_object_t *, ecma_string_t *, bool);
-extern ecma_value_t ecma_op_general_object_default_value (ecma_object_t *, ecma_preferred_type_hint_t);
-extern ecma_value_t ecma_op_general_object_define_own_property (ecma_object_t *, ecma_string_t *,
-                                                                const ecma_property_descriptor_t *, bool);
+ecma_value_t ecma_op_general_object_delete (ecma_object_t *, ecma_string_t *, bool);
+ecma_value_t ecma_op_general_object_default_value (ecma_object_t *, ecma_preferred_type_hint_t);
+ecma_value_t ecma_op_general_object_define_own_property (ecma_object_t *, ecma_string_t *,
+                                                         const ecma_property_descriptor_t *, bool);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-objects.h

@@ -26,29 +26,29 @@
  * @{
  */
 
-extern ecma_property_t ecma_op_object_get_own_property (ecma_object_t *, ecma_string_t *,
-                                                        ecma_property_ref_t *, uint32_t);
-extern ecma_property_t ecma_op_object_get_property (ecma_object_t *, ecma_string_t *,
-                                                    ecma_property_ref_t *, uint32_t);
-extern bool ecma_op_object_has_own_property (ecma_object_t *, ecma_string_t *);
-extern bool ecma_op_object_has_property (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_object_find_own (ecma_value_t, ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_object_find (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_object_get_own_data_prop (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_object_get (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_object_put (ecma_object_t *, ecma_string_t *, ecma_value_t, bool);
-extern ecma_value_t ecma_op_object_delete (ecma_object_t *, ecma_string_t *, bool);
-extern ecma_value_t ecma_op_object_default_value (ecma_object_t *, ecma_preferred_type_hint_t);
-extern ecma_value_t ecma_op_object_define_own_property (ecma_object_t *, ecma_string_t *,
-                                                        const ecma_property_descriptor_t *, bool);
-extern bool ecma_op_object_get_own_property_descriptor (ecma_object_t *, ecma_string_t *,
-                                                        ecma_property_descriptor_t *);
-extern ecma_value_t ecma_op_object_has_instance (ecma_object_t *, ecma_value_t);
-extern bool ecma_op_object_is_prototype_of (ecma_object_t *, ecma_object_t *);
-extern ecma_collection_header_t * ecma_op_object_get_property_names (ecma_object_t *, bool, bool, bool);
+ecma_property_t ecma_op_object_get_own_property (ecma_object_t *, ecma_string_t *,
+                                                 ecma_property_ref_t *, uint32_t);
+ecma_property_t ecma_op_object_get_property (ecma_object_t *, ecma_string_t *,
+                                             ecma_property_ref_t *, uint32_t);
+bool ecma_op_object_has_own_property (ecma_object_t *, ecma_string_t *);
+bool ecma_op_object_has_property (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_object_find_own (ecma_value_t, ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_object_find (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_object_get_own_data_prop (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_object_get (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_object_put (ecma_object_t *, ecma_string_t *, ecma_value_t, bool);
+ecma_value_t ecma_op_object_delete (ecma_object_t *, ecma_string_t *, bool);
+ecma_value_t ecma_op_object_default_value (ecma_object_t *, ecma_preferred_type_hint_t);
+ecma_value_t ecma_op_object_define_own_property (ecma_object_t *, ecma_string_t *,
+                                                 const ecma_property_descriptor_t *, bool);
+bool ecma_op_object_get_own_property_descriptor (ecma_object_t *, ecma_string_t *,
+                                                 ecma_property_descriptor_t *);
+ecma_value_t ecma_op_object_has_instance (ecma_object_t *, ecma_value_t);
+bool ecma_op_object_is_prototype_of (ecma_object_t *, ecma_object_t *);
+ecma_collection_header_t * ecma_op_object_get_property_names (ecma_object_t *, bool, bool, bool);
 
-extern lit_magic_string_id_t ecma_object_get_class_name (ecma_object_t *);
-extern bool ecma_object_class_is (ecma_object_t *, uint32_t);
+lit_magic_string_id_t ecma_object_get_class_name (ecma_object_t *);
+bool ecma_object_class_is (ecma_object_t *, uint32_t);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-reference.h

@@ -26,8 +26,8 @@
  * @{
  */
 
-extern ecma_object_t *ecma_op_resolve_reference_base (ecma_object_t *, ecma_string_t *);
-extern ecma_value_t ecma_op_resolve_reference_value (ecma_object_t *, ecma_string_t *);
+ecma_object_t *ecma_op_resolve_reference_base (ecma_object_t *, ecma_string_t *);
+ecma_value_t ecma_op_resolve_reference_value (ecma_object_t *, ecma_string_t *);
 
 /**
  * @}

jerry-core/ecma/operations/ecma-string-object.h

@@ -25,10 +25,10 @@
  * @{
  */
 
-extern ecma_value_t
+ecma_value_t
 ecma_op_create_string_object (const ecma_value_t *, ecma_length_t);
 
-extern void
+void
 ecma_op_string_list_lazy_property_names (ecma_object_t *,
                                          bool,
                                          ecma_collection_header_t *,