YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed toFixed method string conversion (#2112)

Browse Source 
This patch fixes #2108. The problem was if the convertible number had less significant fractions digits than the requested, the result was filled with memory junk instead of zeros.

JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
This commit is contained in:
rerobika
2017-11-17 20:00:45 +01:00
committed by László Langó
parent 6c06a309c1
commit 1dedc1b630
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.c
+2 -4
View File
@@ -128,7 +128,6 @@ ecma_builtin_number_prototype_helper_to_string (lit_utf8_byte_t *digits_p, /**<
static inline lit_utf8_size_t __attr_always_inline___
ecma_builtin_binary_floating_number_to_string (lit_utf8_byte_t *digits_p, /**< number as string
* in binary-floating point number */
lit_utf8_size_t num_digits, /**< length of the string representation */
int32_t exponent, /**< decimal exponent */
lit_utf8_byte_t *to_digits_p, /**< [out] buffer to write */
lit_utf8_size_t to_num_digits) /**< requested number of digits */
@@ -149,10 +148,10 @@ ecma_builtin_binary_floating_number_to_string (lit_utf8_byte_t *digits_p, /**< n
if (to_num_digits > 0)
{
/* Add significant digits of the fraction part. */
/* Add significant digits of the fraction part and fill the remaining digits with zero */
while (to_num_digits > 0)
{
*p++ = num_digits == 1 ? '0' : *digits_p++;
*p++ = (*digits_p == 0 ? '0' : *digits_p++);
to_num_digits--;
}
}
@@ -680,7 +679,6 @@ ecma_builtin_number_prototype_object_to_fixed (ecma_value_t this_arg, /**< this
lit_utf8_size_t to_num_digits = ((exponent > 0) ? (lit_utf8_size_t) (exponent + frac_digits)
: (lit_utf8_size_t) (frac_digits + 1));
p += ecma_builtin_binary_floating_number_to_string (digits,
num_digits,
exponent,
p,
to_num_digits);