YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use ecma_number_t instead of double where possible (#2330)

Browse Source 
Some code paths explicitly used double instead of ecma_number_t
even though the values assigned from or compared to were of type
ecma_value_t.

Related to #2251

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
This commit is contained in:
Akos Kiss
2018-05-16 02:17:34 +02:00
committed by yichoi
parent 38f0dbf065
commit 19451fa2d1
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
jerry-core/ecma/builtin-objects/ecma-builtin-number-prototype.c
+1 -1
View File
@@ -303,7 +303,7 @@ ecma_builtin_number_prototype_object_to_string (ecma_value_t this_arg, /**< this
* cases that can cause incorrect results due to precision issues, so we use a loop instead. * cases that can cause incorrect results due to precision issues, so we use a loop instead.
*/ */
magnitude = 0; magnitude = 0;
double counter = this_arg_number; ecma_number_t counter = this_arg_number;
while (counter >= radix) while (counter >= radix)
{ {
counter /= radix; counter /= radix;
jerry-core/ecma/builtin-objects/typedarray/ecma-builtin-typedarray-prototype.c
+1 -1
View File
@@ -680,7 +680,7 @@ ecma_builtin_typedarray_prototype_set (ecma_value_t this_arg, /**< this argument
{ {
target_offset_num = 0; target_offset_num = 0;
} }
if (target_offset_num <= -1.0 || target_offset_num >= (double) UINT32_MAX + 0.5) if (target_offset_num <= -1.0 || target_offset_num >= (ecma_number_t) UINT32_MAX + 0.5)
{ {
return ecma_raise_range_error (ECMA_ERR_MSG ("Invalid offset")); return ecma_raise_range_error (ECMA_ERR_MSG ("Invalid offset"));
} }
jerry-core/ecma/operations/ecma-arraybuffer-object.c
+1 -1
View File
@@ -138,7 +138,7 @@ ecma_op_create_arraybuffer_object (const ecma_value_t *arguments_list_p, /**< li
const uint32_t maximum_size_in_byte = UINT32_MAX - sizeof (ecma_extended_object_t) - JMEM_ALIGNMENT + 1; const uint32_t maximum_size_in_byte = UINT32_MAX - sizeof (ecma_extended_object_t) - JMEM_ALIGNMENT + 1;
if (length_num <= -1.0 || length_num > (double) maximum_size_in_byte + 0.5) if (length_num <= -1.0 || length_num > (ecma_number_t) maximum_size_in_byte + 0.5)
{ {
return ecma_raise_range_error (ECMA_ERR_MSG ("Invalid ArrayBuffer length.")); return ecma_raise_range_error (ECMA_ERR_MSG ("Invalid ArrayBuffer length."));
} }