YourWishes/jerryscript
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing value copying/value leakage issues.

Browse Source
This commit is contained in:
Ruben Ayrapetyan
2014-07-21 17:39:39 +04:00
parent 0ff6d7ae9e
commit 1175526d52
7 changed files with 80 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libecmaobjects/ecma-helpers-value.c
+30 -4
View File
@@ -121,6 +121,9 @@ ecma_MakeObjectValue( ecma_Object_t* object_p) /**< object to reference in value
* increase reference counter of the object
* and return the value as it was passed.
*
* TODO:
* reference counter in strings
*
* @return See note.
*/
ecma_Value_t
@@ -182,7 +185,7 @@ ecma_CopyValue( const ecma_Value_t value) /**< ecma-value */
} /* ecma_CopyValue */
/**
* Free memory used for the value
* Free the ecma-value
*/
void
ecma_FreeValue( ecma_Value_t value) /**< value description */
@@ -224,6 +227,8 @@ ecma_FreeValue( ecma_Value_t value) /**< value description */
/**
* Completion value constructor
*
* @return completion value
*/
ecma_CompletionValue_t
ecma_MakeCompletionValue(ecma_CompletionType_t type, /**< type */
@@ -235,21 +240,42 @@ ecma_MakeCompletionValue(ecma_CompletionType_t type, /**< type */
/**
* Throw completion value constructor.
*
* @return 'throw' completion value
*/
ecma_CompletionValue_t
ecma_MakeThrowValue( ecma_Object_t *exception_p) /**< an object */
{
JERRY_ASSERT( exception_p != NULL && !exception_p->m_IsLexicalEnvironment );
ecma_Value_t exception;
exception.m_ValueType = ECMA_TYPE_OBJECT;
ecma_SetPointer( exception.m_Value, exception_p);
ecma_Value_t exception = ecma_MakeObjectValue( exception_p);
return ecma_MakeCompletionValue(ECMA_COMPLETION_TYPE_THROW,
exception,
ECMA_TARGET_ID_RESERVED);
} /* ecma_MakeThrowValue */
/**
* Free the completion value.
*/
void
ecma_free_completion_value( ecma_CompletionValue_t completion_value) /**< completion value */
{
switch ( completion_value.type )
{
case ECMA_COMPLETION_TYPE_NORMAL:
case ECMA_COMPLETION_TYPE_THROW:
case ECMA_COMPLETION_TYPE_RETURN:
ecma_FreeValue( completion_value.value);
break;
case ECMA_COMPLETION_TYPE_CONTINUE:
case ECMA_COMPLETION_TYPE_BREAK:
case ECMA_COMPLETION_TYPE_EXIT:
JERRY_ASSERT( completion_value.value.m_ValueType == ECMA_TYPE_SIMPLE );
break;
}
} /* ecma_free_completion_value */
/**
* Check if the completion value is specified normal simple value.
*
src/libecmaobjects/ecma-helpers.h
+1
View File
@@ -54,6 +54,7 @@ extern void ecma_FreeValue( const ecma_Value_t value);
extern ecma_CompletionValue_t ecma_MakeCompletionValue( ecma_CompletionType_t type, ecma_Value_t value, uint8_t target);
extern ecma_CompletionValue_t ecma_MakeThrowValue( ecma_Object_t *exception_p);
extern void ecma_free_completion_value( ecma_CompletionValue_t completion_value);
extern bool ecma_is_completion_value_normal_simple_value( ecma_CompletionValue_t value, ecma_SimpleValue_t simple_value);
extern bool ecma_IsCompletionValueNormalFalse( ecma_CompletionValue_t value);