Add support for new.target (#3469)
Notable changes:
* Extracted the pure JS/builtin and external C method invocations
into two new methods (`ecma_op_function_call_{simple, external}`).
* Updated parser/scanner to handle "new.target" correctly.
* Added JS test case.
JerryScript-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com
This commit is contained in:
committed by
Robert Fancsik
parent
be8ae3aae8
commit
0fd1ed6f27
@@ -0,0 +1,20 @@
|
||||
/* Copyright JS Foundation and other contributors, http://js.foundation
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
async function async_method () {
|
||||
assert (new.target === undefined);
|
||||
}
|
||||
|
||||
async_method ();
|
||||
@@ -0,0 +1,63 @@
|
||||
/* Copyright JS Foundation and other contributors, http://js.foundation
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
class Simple {
|
||||
constructor () {
|
||||
assert (new.target === Simple);
|
||||
this.called = 0;
|
||||
}
|
||||
|
||||
get getter () {
|
||||
this.called++;
|
||||
return new.target;
|
||||
}
|
||||
|
||||
set setter (val) {
|
||||
assert (new.target === undefined);
|
||||
this.called++;
|
||||
}
|
||||
}
|
||||
|
||||
var smp = new Simple ();
|
||||
assert (smp.getter === undefined);
|
||||
assert (smp.called === 1);
|
||||
smp.setter = -1;
|
||||
assert (smp.called === 2);
|
||||
|
||||
class BaseA {
|
||||
constructor () {
|
||||
assert (new.target === SubA);
|
||||
}
|
||||
}
|
||||
|
||||
class SubA extends BaseA {
|
||||
constructor () {
|
||||
super ();
|
||||
assert (new.target === SubA);
|
||||
}
|
||||
}
|
||||
|
||||
new SubA ();
|
||||
|
||||
/* TODO: enable if there is class name support. */
|
||||
/*
|
||||
class Named {
|
||||
constructor () {
|
||||
assert(new.target.name == "Named");
|
||||
}
|
||||
}
|
||||
|
||||
new Named ();
|
||||
*/
|
||||
@@ -0,0 +1,33 @@
|
||||
/* Copyright JS Foundation and other contributors, http://js.foundation
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
function *demo_gen () {
|
||||
for (var idx = 0; idx < 3; idx++)
|
||||
{
|
||||
assert (new.target === undefined);
|
||||
yield idx;
|
||||
assert (new.target === undefined);
|
||||
}
|
||||
}
|
||||
|
||||
var gen = demo_gen ();
|
||||
|
||||
var value = 0;
|
||||
for (var item of gen)
|
||||
{
|
||||
value = item;
|
||||
}
|
||||
|
||||
assert (value === 2);
|
||||
@@ -0,0 +1,137 @@
|
||||
/* Copyright JS Foundation and other contributors, http://js.foundation
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
function null_target () {
|
||||
assert (new.target === undefined);
|
||||
}
|
||||
|
||||
function demo () {
|
||||
null_target ();
|
||||
return new.target;
|
||||
}
|
||||
|
||||
assert (demo () === undefined);
|
||||
assert ((new demo ()) === demo);
|
||||
|
||||
/* new.target is only valid inside functions */
|
||||
try {
|
||||
eval ("new.target");
|
||||
assert (false);
|
||||
} catch (ex) {
|
||||
assert (ex instanceof SyntaxError);
|
||||
}
|
||||
|
||||
try {
|
||||
var eval_other = eval;
|
||||
eval_other ("new.target");
|
||||
assert (false);
|
||||
} catch (ex) {
|
||||
assert (ex instanceof SyntaxError);
|
||||
}
|
||||
|
||||
/* test with arrow function */
|
||||
var arrow_called = false;
|
||||
function arrow () {
|
||||
assert (new.target === arrow);
|
||||
var mth = () => { return new.target; }
|
||||
assert (mth () === arrow);
|
||||
arrow_called = true;
|
||||
}
|
||||
|
||||
new arrow ();
|
||||
assert (arrow_called === true);
|
||||
|
||||
/* test unary operation */
|
||||
var f_called = false;
|
||||
function f () {
|
||||
assert (isNaN (-new.target));
|
||||
f_called = true;
|
||||
}
|
||||
|
||||
new f ();
|
||||
assert (f_called === true);
|
||||
|
||||
/* test property access */
|
||||
function fg (callback_object) {
|
||||
callback_object.value = new.target.value;
|
||||
}
|
||||
|
||||
fg.value = 22;
|
||||
|
||||
var test_obj = {};
|
||||
new fg (test_obj);
|
||||
|
||||
assert (test_obj.value === 22);
|
||||
|
||||
|
||||
/* test new.target with eval */
|
||||
function eval_test () {
|
||||
var target = eval ("new.target");
|
||||
assert (target === eval_test);
|
||||
}
|
||||
|
||||
new eval_test ();
|
||||
|
||||
function eval_eval_test () {
|
||||
var target = eval ('eval("new.target")');
|
||||
assert (target === eval_eval_test);
|
||||
}
|
||||
|
||||
new eval_eval_test ();
|
||||
|
||||
|
||||
/* test assignment of the "new.target" */
|
||||
function expect_syntax_error (src)
|
||||
{
|
||||
try {
|
||||
eval (src);
|
||||
assert (false);
|
||||
} catch (ex) {
|
||||
assert (ex instanceof SyntaxError);
|
||||
}
|
||||
}
|
||||
|
||||
expect_syntax_error ("function assign () { new.target = 3; }");
|
||||
expect_syntax_error ("function assign () { new.target += 3; }");
|
||||
expect_syntax_error ("function assign () { new.target *= 3; }");
|
||||
expect_syntax_error ("function assign () { new.target -= 3; }");
|
||||
expect_syntax_error ("function assign () { new.target |= 3; }");
|
||||
expect_syntax_error ("function assign () { new.target &= 3; }");
|
||||
|
||||
expect_syntax_error ("function assign () { new.target++; }");
|
||||
expect_syntax_error ("function assign () { ++new.target; }");
|
||||
expect_syntax_error ("function assign () { new.target--; }");
|
||||
expect_syntax_error ("function assign () { --new.target; }");
|
||||
|
||||
expect_syntax_error ("function synt () { new....target; }");
|
||||
|
||||
function delete_test () {
|
||||
assert ((delete new.target) === true);
|
||||
}
|
||||
|
||||
new delete_test ();
|
||||
|
||||
function binary_test_1 () {
|
||||
/*/ new.target is converted to string */
|
||||
assert ((new.target + 1) === "function(){/* ecmascript */}1");
|
||||
}
|
||||
function binary_test_2 () { assert (isNaN (new.target - 3)); }
|
||||
function binary_test_3 () { assert (isNaN (new.target * 2)); }
|
||||
function binary_test_4 () { assert (isNaN (new.target / 4)); }
|
||||
|
||||
new binary_test_1 ();
|
||||
new binary_test_2 ();
|
||||
new binary_test_3 ();
|
||||
new binary_test_4 ();
|
||||
Reference in New Issue
Block a user