Remove bad assertion in ecma_builtin_json_str_helper (#2521)

Fixes #2494

JerryScript-DCO-1.0-Signed-off-by: Peter Marki marpeter@inf.u-szeged.hu

jerry-core/ecma/builtin-objects/ecma-builtin-json.c

@@ -923,13 +923,16 @@ static ecma_value_t ecma_builtin_json_str_helper (const ecma_value_t arg1, /**<
                                                   empty_str_p,
                                                   arg1,
                                                   false);
-  JERRY_ASSERT (ecma_is_value_true (put_comp_val));
+
-  ecma_free_value (put_comp_val);
+  if (ecma_is_value_true (put_comp_val))
-  ECMA_TRY_CATCH (str_val,
+  {
-                  ecma_builtin_json_str (empty_str_p, obj_wrapper_p, &context),
+    ret_value = ecma_builtin_json_str (empty_str_p, obj_wrapper_p, &context);
-                  ret_value);
+  }
-  ret_value = ecma_copy_value (str_val);
+  else
-  ECMA_FINALIZE (str_val);
+  {
+    ret_value = ECMA_VALUE_UNDEFINED;
+  }
+
   ecma_free_value (put_comp_val);
   ecma_deref_ecma_string (empty_str_p);
   ecma_deref_object (obj_wrapper_p);

tests/jerry/regression-test-issue-2494.js

@@ -0,0 +1,16 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+Object.defineProperty(Object.prototype, "", {});
+assert(JSON.stringify() === undefined)