From 063e7fde2b5afc547068a461c3609c4d7898a5d1 Mon Sep 17 00:00:00 2001 From: Robert Fancsik Date: Fri, 10 May 2019 10:47:25 +0200 Subject: [PATCH] undefined byteLength should be treated 0 in DataView constructor (#2856) This patch fixes #2854. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu --- .../ecma/operations/ecma-dataview-object.c | 6 +++++- .../jerry/es2015/regression-test-issue-2854.js | 18 ++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 tests/jerry/es2015/regression-test-issue-2854.js diff --git a/jerry-core/ecma/operations/ecma-dataview-object.c b/jerry-core/ecma/operations/ecma-dataview-object.c index 94b369612..6d02ad548 100644 --- a/jerry-core/ecma/operations/ecma-dataview-object.c +++ b/jerry-core/ecma/operations/ecma-dataview-object.c @@ -112,7 +112,11 @@ ecma_op_dataview_create (const ecma_value_t *arguments_list_p, /**< arguments li int32_t byte_length_int32 = ecma_number_to_int32 (byte_length); - if (ecma_number_is_infinity (byte_length)) + if (ecma_number_is_nan (byte_length)) + { + viewByteLength = 0; + } + else if (ecma_number_is_infinity (byte_length)) { viewByteLength = UINT32_MAX; } diff --git a/tests/jerry/es2015/regression-test-issue-2854.js b/tests/jerry/es2015/regression-test-issue-2854.js new file mode 100644 index 000000000..3e7d8009a --- /dev/null +++ b/tests/jerry/es2015/regression-test-issue-2854.js @@ -0,0 +1,18 @@ +// Copyright JS Foundation and other contributors, http://js.foundation +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +var buffer = new ArrayBuffer() +var dataView = new DataView(buffer, 0, undefined) + +assert(dataView.byteLength === 0);